vimalloc / vimalloc/flask-jwt-extended

Support OOP-style callbacks

Open
#333 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.6k
Forks
253
PR merge metrics
No merged PRs in 30d

Description

I’d love to see the possibly of simply sub-classing JWTManager and overwriting methods instead of defining callbacks using decorators. Currently it’s not possible to do that because the default callbacks are set in JWTManager.__init__() and thereby can only be overwritten after the manager has been instantiated.

Is there an advantage of registering the callbacks using decorators or is this just syntactic-sugar?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading JWTManager.init and the existing decorator-based callback registration described in the issue. Determine how subclass-overridden methods could coexist with the current defaults, and clarify the expected callback precedence and completion criteria before making changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
flask, python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.