vim-jp / vim-jp/vim-jp.github.io

Patchesの表示が冗長

Open
#241 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
96
Forks
28
PR merge metrics
No merged PRs in 30d

Description

ページの右側に表示されるPatchesの表示が冗長に思います。

vim-jp-patches

この例だと、patch 8.0.0454: compiler warnings for "always true" comparison の部分は不要だと思います。また、"" として表示されるべきでしょう。

--- a/assets/javascripts/patch-list.js
+++ b/assets/javascripts/patch-list.js
@@ -5,7 +5,7 @@ $(function() {
     $.each(items, function() {
       $('<li/>').append(
         $('<a/>').attr({'href': this.link, 'target': '_blank'}).text("Patch " + this.title)
-      ).append($('<br/>')).append($('<span/>').text(this.description)).appendTo('#patches-list');
+      ).append($('<br/>')).append($('<span/>').text(this.description.replace(/^[^\n]*\n\n/, '').replace(/&quot;/g, '"'))).appendTo('#patches-list');
     });
   });
 });

とりあえず、こんなパッチを当てれば表示は改善されますが、これでいいのかは分かりません。
また、&quot; だけではなく、&lt;, &gt;, &amp; なども対応が必要かもしれません。

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with assets/javascripts/patch-list.js and inspect how each patch title and description are assembled for the Patches list. Verify the displayed result against the issue screenshot and proposed diff, including removal of the redundant prefix and handling of HTML entities such as ", <, >, and &. Done means the right-side patch descriptions are concise and display the intended characters correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.