videolan / videolan/libspatialaudio
Remove need for _USE_MATH_DEFINES
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 317
- Forks
- 60
- PR merge metrics
- No merged PRs in 30d
Description
Once we can break API/ABI, remove/encapsulate things accordingly to not need to expose this define to library users.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin by tracing where _USE_MATH_DEFINES is required and which public interface exposes that requirement. Establish the API/ABI-breaking scope and verify consumers no longer need to define it; the issue names no specific files, entry points, or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100