videolan / videolan/libspatialaudio
Debug logs always printed
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 317
- Forks
- 60
- PR merge metrics
- No merged PRs in 30d
Description
There are some uses of std::cout that result on log lines always being printed. For example these two:
https://github.com/videolabs/libspatialaudio/blob/master/source/AmbisonicBinauralizer.cpp#L362
https://github.com/videolabs/libspatialaudio/blob/master/source/AmbisonicBinauralizer.cpp#L367
Would be nice to have some setting to only print these in debug mode.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with source/AmbisonicBinauralizer.cpp at the two linked locations and inspect nearby uses of std::cout. Determine how debug-mode output is configured in the project, then ensure these log lines are not printed during normal use. Confirm that the affected paths remain quiet outside debug mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100