Support I-Frame requests of Interstitials on integrated timeline

Open
#7,781 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
typescript

Research direction

Start by tracing loadMediaAt and the interstitial preloading flow for the hlsIFramesOnly and primary Hls instances. Verify how an optional integrated or primary timeline is resolved and how both instances share asset results. Done means integrated-timeline I-frame requests work for range-occupying interstitials, while primary remains the default and point-occupancy interstitials load no iframes.

Written by the indexing model from the issue text.

Description

Interstitials

Add an optional timeline argument to loadMediaAt which accepts values of "integrated" and "primary" (default), so that hlsIFramesOnly.loadMediaAt(time) can be used relative to an integrated timeline for content with interstitials.

Changes should also ensure that interstitial (pre)loading is handled such that the IFramesOnly and primary (Hls) instances use the same asset results.

Note that interstitials without X-TIMELINE-OCCUPIES=RANGE (POINT occupancy) would not have any iframes loaded.

Dominant language
TypeScript
Stars
16.9k
Forks
2.8k
Avg merge
1d 12h
Merged PRs (30d)
27

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from video-dev/hls.js

All issues in video-dev/hls.js

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.