vesoft-inc / vesoft-inc/nebula-java
Need more explicit exceptions so its easier to test in application code
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 199
- Forks
- 125
- Avg merge
- 5h 6m
- Merged PRs (30d)
- 3
Description
For instance
new RuntimeException(
"Switch space `"
+ config.getSpaceName()
+ "' failed: "
+ resultSet.getErrorMessage());
If this was a NoSpaceFoundException it would be easier to test. Frequently we'd like know if an exception is one we can retry so having ones that implement TransitentException or some ClientException is helpful.
For instance this NoSpaceFoundException is not retryable.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the RuntimeException construction shown in the issue and the existing NoSpaceFoundException, then review the TransientException and ClientException types. Done means relevant client failures use explicit exception types whose retryability can be distinguished in application tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100