vert-x3 / vert-x3/vertx-stack

Resolve command logback logging problem

Open
#86 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
123
Forks
45
PR merge metrics
No merged PRs in 30d

Description

I just started playing with stack manager resolve command. Apparently, there is some issue with the logger used by the stack manager that throws following messages on console:

./vertx.sh resolve

2018-03-29 12:20:41.182 [main] INFO  stack-manager-cache - Set resolver cache to /Users/marcin.czeczko/Work/vertx-cli-starter/vertx/.stack-manager-cache.json
2018-03-29 12:20:41.185 [main] INFO  stack-manager-cache - Loading resolver cache from /Users/marcin.czeczko/Work/vertx-cli-starter/vertx/.stack-manager-cache.json
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

What I did is:

  • Used vertx-cli-starter project
  • Added slf4j-api, logback-classic, logback-core jars to lib/ and to the vertx-stack.json as dependencies
  • To the java exec command I added -Dvertx.logger-delegate-factory-class-name=io.vertx.core.logging.SLF4JLogDelegateFactory

The effects are:

  • When running vertx resolve command prints out the SLF4J error about StaticLoggerBinder
  • If I run my verticle that uses logging it works just fine.

It seems that stack-manager is using different logging api. Could you please advice how can it be solved ?

Btw. the reproducer is here: https://github.com/marcinczeczko/vertx-starter-logger-issue

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the vertx resolve command with the vertx-cli-starter project and its vertx-stack.json dependencies. Compare the stack manager's Java execution path with the verticle run described in the issue, focusing on why the SLF4J binding is unavailable during resolve. Done means the resolve command no longer prints the StaticLoggerBinder warning while the reported logging behavior remains functional.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.