vercel / vercel/resumable-stream

Unnecessary redis dependency when using ioredis

Open
#8 6 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
574
Forks
44
Avg merge
3m
Merged PRs (30d)
1

Description

Hi everyone 👋

First, thanks for adding support for ioredis—really appreciated!

I noticed that the package still has a dependency on the redis client, even when using an ioredis publisher/subscriber. This seems unnecessary and can cause issues for users who are only using ioredis.

Issue
Even if you're not using the redis client directly, you still need to install it because it's a required dependency. Otherwise, the package crashes at runtime.

Steps to reproduce:
Create a project with ioredis and this package installed.

Do not install the redis package.

Attempt to use this package with ioredis.

Expected behavior:
It should work without requiring redis to be installed.

Actual behavior:
The package throws an error due to the missing redis dependency, even though it's not being used. "Cannot find module 'redis'"

Let me know if you need any more details or if I can help with a PR!

Best,
Antoine

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure with this package and ioredis installed but without the redis package. Inspect the package dependency declarations and the runtime path that loads the Redis client; done means ioredis-only usage works without a missing-module error, while direct redis usage remains supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
redis, typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.