vercel / vercel/resumable-stream
Leak of sensitive information through debug logs
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 574
- Forks
- 44
- Avg merge
- 3m
- Merged PRs (30d)
- 1
Description
The library checks for the presence of the DEBUG env var, and logs all inputs to the stream if present.
This led to a production issue in our case, as we use the widely-used debug npm library, which has the concept of namespaces. E.g. if DEBUG=myapp:*, only "myapp" logs should be produced. This library clashes with that.
Due to a recent security alert, I don't think we should introduce the debug library as a dependency, but since it is still very widely used, there is a risk of sensitive information leakage for any service using it with this library, so I think it should be compatible with it.
I have submitted a PR that does that.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the DEBUG environment-variable handling described in the issue and compare it with the namespace behavior of the debug npm library. Review pull request #31 to understand the proposed compatibility change; done means avoiding unintended sensitive-input logging while preserving the intended debug output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, typescript
- Domain
- security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 20/100