vercel / vercel/nft

Track line number additionally to file name for inclusion reason

Open
#209 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
1.7k
Forks
185
PR merge metrics
No merged PRs in 30d

Description

Would it be possible for nft to track the line number that caused it to include something in the tree vs. just the file/parent? Then it would be trivial to look at the correct code to figure out what lead to an inclusion in the archive.

(Extracted from https://github.com/vercel/nft/issues/203#issuecomment-842629092)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name any files, tests, or entry points. Start by tracing how nft records and reports the file or parent responsible for an inclusion, then inspect existing coverage for inclusion reasons. Done means the reported reason also identifies the causing line and tests verify that information.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.