vercel / vercel/ncc

jsonc-parser

Open
#960 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
9.8k
Forks
326
PR merge metrics
No merged PRs in 30d

Description

Hello,

I'm using ncc to bundle a vscode extension which is using the jsonc-parser library.
With v3.0.0, I don't have any issue.
With v3.1.0, ncc doesn't produce any errors but when running the extension, I get Cannot find module './format'

Do you have any advice?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the VS Code extension bundle with ncc and jsonc-parser v3.1.0, then compare the result with v3.0.0. Investigate why the generated bundle still requests './format'; done means the extension runs without the Cannot find module error and the regression is covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.