Invalid assignment on 0.28.x (superagent as dependency)
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 9.8k
- Forks
- 326
- PR merge metrics
- No merged PRs in 30d
Description
Works fine with <= 0.27.0, when 0.28.x does not build one file, that has superagent as dependency:
...\node_modules\@vercel\ncc\dist\ncc/index.js.cache.js:20
<code>
JS_Parse_Error [SyntaxError]: Invalid assignment
at js_error (\node_modules\@vercel\ncc\dist\ncc/index.js.cache.js:20:163522)
at croak (\node_modules\@vercel\ncc\dist\ncc/index.js.cache.js:20:174584)
at maybe_assign (\node_modules\@vercel\ncc\dist\ncc/index.js.cache.js:20:204547)
at expression (\node_modules\@vercel\ncc\dist\ncc/index.js.cache.js:20:204656)
at simple_statement (\node_modules\@vercel\ncc\dist\ncc/index.js.cache.js:20:179275)
at statement (\node_modules\@vercel\ncc\dist\ncc/index.js.cache.js:20:176763)
at _embed_tokens_wrapper (\node_modules\@vercel\ncc\dist\ncc/index.js.cache.js:20:175715)
at if_ (\node_modules\@vercel\ncc\dist\ncc/index.js.cache.js:20:187029)
at statement (\node_modules\@vercel\ncc\dist\ncc/index.js.cache.js:20:177758)
at _embed_tokens_wrapper (\node_modules\@vercel\ncc\dist\ncc/index.js.cache.js:20:175715) {
filename: '0',
line: 2338,
col: 45,
pos: 54545
}
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the build with superagent as a dependency, comparing ncc 0.27.0 with 0.28.x. Inspect node_modules/@vercel/ncc/dist/ncc/index.js.cache.js around line 2338 and the reported parser failure; done means the affected file builds successfully on 0.28.x.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100