vercel / vercel/ncc

specify extra files to bundle in package.json

Open
#503 0 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
9.8k
Forks
326
PR merge metrics
No merged PRs in 30d

Description

I know ncc tries hard to guess what needs to be bundled but sometimes there are non-js resources like images and/or sqlite databases for example. Another possible use-case would be to bundle /work/ directory so that the app doesn't need to check for its presence.

I think the best solution would be to specify glob patterns in the package.json file.

I'd be willing to implement that if you're ok with the idea.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating ncc's package.json processing and reviewing how bundled resources are currently discovered. Define the glob-pattern configuration and its behavior for non-JavaScript files and directories such as /work/. Done means the agreed package.json configuration bundles those resources reliably, with tests covering the supported patterns.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.