Support Reporting Terminal Window in Pixels
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 44.7k
- Forks
- 3.6k
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
- OS version and name: Mac OSX 10.12 (16A323)
- Hyper.app version: 0.8.3.873
Issue
threejs-tern requires the actual pixel size of the terminal so it would be able to render a 3d scene with a more accurate aspect ratio.
At the point of testing, Hyper does not seems to support pixel dimension reporting (although terminal size reporting and mouse works which is pretty cool!)
Some code related to this issue is here.
- https://github.com/zz85/threejs-term/blob/master/dom_polyfill.js#L106
- https://github.com/chjj/blessed/blob/master/lib/program.js#L3917
This issue isn't present using iTerm2 or Mac's Terminal.app.
I'm not too familiar with the internals of Hyper, but my guess is that a fix for this issue would be to implement the CSI sequence P 1 4.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading threejs-tern's dom_polyfill.js and blessed's program.js at the linked locations to understand the expected pixel-size query and response. Trace Hyper's terminal reporting and CSI handling, then verify that CSI sequence P 1 4 returns the terminal window dimensions in pixels.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100