Dragging tabs not possible by preventing default on mouse down on Header
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 44.7k
- Forks
- 3.6k
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
Hi,
this line prevents drag&drop API from working on anything inside Header component (in my case, it's tabs).
This is blocking https://github.com/patrik-piskay/hyperterm-tabs/issues/6 and it was working correctly until 0.8 (this release introduced the ev.preventDefault() line). Is there a better solution or at least a possibility to override the default onMouseDown handler?
I am happy to submit a PR that will fix this, just want to discuss possible approaches.
Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect lib/components/header.js at the referenced line and review the discussion around the drag-and-drop behavior. Reproduce dragging tabs inside Header and determine how the mouse-down handling affects it. Done means tab dragging works without breaking the existing Header behavior or the blocked hyperterm-tabs use case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100