vercel / vercel/hyper

Incorrect initial notifications

Open
#868 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

❣️ Priority: High 🐛 Type: Bug
Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

The experience of installing Hyper from scratch has a few issues:

  • It shows a notification that "plugins were installed", when simply the directory is just being initialized. No plugins were installed
  • When you first change the configuration, it thinks the shell has changed and displays a notification. The default value of the shell in the config is '', should be null, and the comparison should consider both nully[1] and not show the notification.

[1] just coined this, derivative of falsy 🙈

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the first-run installation and configuration-change notification paths described in the issue, starting with the initialization behavior and the shell value comparison. Done means a fresh install does not report plugins as installed, and the first configuration change does not report a shell change when the shell value is unset.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.