Wrong precedence order for customizations vs. themes
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 44.7k
- Forks
- 3.6k
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
- I am on the latest Hyper.app version
- I have searched the issues of this repo and believe that this is not a duplicate
- OS version and name: macOS Sequoia
- Hyper.app version: 3.4.1
- Link of a Gist with the contents of your hyper.json: Defaults
- The issue is reproducible in vanilla Hyper.app: Is Vanilla
Issue
When applying a theme, then many of the options for customizing colors are blatantly ignored. The configuration loading precedence order is incorrect.
Please apply any configured themes, and then apply any custom colors to override the theme.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named in the issue. Start by tracing configuration loading and theme application in the Hyper.app code, then verify that configured themes are applied before custom colors and that custom colors override them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100