vercel / vercel/hyper

Support forward slashes on Windows

Open
#8,040 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

Is your feature request related to a problem? Please describe.

I use some hyper config that I'd like to share across Windows and Unix hosts. Since Windows generally supports forward slashes, it would be nice if Hyper would do the same when on Windows, allowing a config to be shared across platforms. For example:

    shell: '/Users/jaraco/.local/bin/xonsh.exe',

That config doesn't work on Windows and will cause a crash, even if that file exists. Only after translating the forward slashes to backslashes does the application run.

Describe the solution you'd like

Better would be to honor forward slashes on all platforms, making the configuration files more portable. That could be done by translating the forward slashes to backslashes before passing them to Windows APIs... or more likely those paths can simply be used with forward slashes and Hyper merely needs to avoid crashing when forward slashes are supplied on Windows.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by reproducing the Windows crash with the shown shell path and tracing Hyper's configuration handling; done means the same portable config runs on Windows without requiring slash translation, with coverage for this path case.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop, operating-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.