Closing a tab results in a blank screen
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 44.7k
- Forks
- 3.6k
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
- I am on the latest Hyper.app version
- I have searched the issues of this repo and believe that this is not a duplicate
- OS version and name: Mac OS 14.4.1 Sonoma
- Hyper.app version: 2a7bb18259d975f27b30b502af1be7576f6f5656
- Link of a Gist with the contents of your hyper.json: N/A
- Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
<embedded>:23937 Uncaught TypeError: Cannot read properties of undefined (reading 'onRequestRedraw')
at t.RenderService.setRenderer (<embedded>:23937:107471)
at Object.dispose (<embedded>:23933:91675)
at a.dispose (<embedded>:23933:74208)
at t.AddonManager._wrappedAddonDispose (<embedded>:23937:253461)
at t.dispose (<embedded>:23937:253188)
at t.AddonManager.dispose (<embedded>:23937:253070)
at d.dispose (<embedded>:23937:190098)
at d.dispose (<embedded>:23937:282496)
at Terms.componentDidUpdate (terms.tsx:65:1)
at commitLayoutEffectOnFiber (<embedded>:50695:36)
The above error occurred in the <Terms> component:
at Terms (file:///Users/ironmagma/Code/hyper/target/renderer/bundle.js:4796:5)
at DecoratedComponent (file:///Users/ironmagma/Code/hyper/target/renderer/bundle.js:2254:7)
at ConnectFunction (<embedded>:57692:80)
at forwardConnectRef
at div
at div
at file:///Users/ironmagma/Code/hyper/target/renderer/bundle.js:1410:66
at DecoratedComponent (file:///Users/ironmagma/Code/hyper/target/renderer/bundle.js:2192:7)
at DecoratedComponent (file:///Users/ironmagma/Code/hyper/target/renderer/bundle.js:2254:7)
at ConnectFunction (<embedded>:57692:80)
at forwardConnectRef
at Provider (<embedded>:63116:9)
React will try to recreate this component tree from scratch using the error boundary you provided, DecoratedComponent.
- The issue is reproducible in vanilla Hyper.app: Is Vanilla
Issue
Closing a tab with CMD-W (or Shell > Close) results in a blank screen. This occurs on canary but not v4.0.0-canary.5.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Terms.componentDidUpdate in terms.tsx and follow the RenderService.setRenderer and addon disposal calls shown in the error. Reproduce the issue by closing a tab with CMD-W or Shell > Close on canary, compare with v4.0.0-canary.5, and verify that the terminal no longer becomes blank or logs the reported error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- desktop, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100