xterm includes its own hard-coded map
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 44.7k
- Forks
- 3.6k
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
-
I am on the latest Hyper.app version
-
I have searched the issues of this repo and believe that this is not a duplicate
-
OS version and name: macOS 14.3 Sonoma
-
Hyper.app version: latest canary
-
Relevant information from devtools:
DevTools failed to load source map: Could not parse content for file:///hyper/target/xterm.js.map: Unexpected end of JSON input
- The issue is reproducible in vanilla Hyper.app: Yes
Issue
DevTools attempts to load an xterm.js.map file from the target directory.
This is because xterm.js has this at the end of it:
//# sourceMappingURL=xterm.js.map
...which makes sense from xterm's perspective, but not from Hyper's.
Uncertain when exactly this started (I think it's been a while).
Two solutions:
- modify xterm.js to strip out the manual map
- always (or conditionally, I suppose) manually require xterm.js.map
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect how Hyper bundles xterm.js and handles source maps, starting with the generated target/xterm.js and target/xterm.js.map paths shown in the report. Compare the two proposed approaches and verify the chosen handling in vanilla Hyper.app; done means DevTools no longer attempts to parse an invalid xterm.js.map.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system, desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100