vercel / vercel/hyper

add `ManifestDPIAware true` in NSIS installer

Open
#6,585 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 11
  • Hyper.app version: 3.2.3(latest)
  • Link of a Gist with the contents of your .hyper.js: none
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): none
  • The issue is reproducible in vanilla Hyper.app: Yes

Issue

I found this cool terminal and downloaded the installer for the Windows 64-bit version from the home page.
When I excitedly launched the installer, the installer screen was jaggy and did not support high resolution DPI.

This may discourage new users a bit.

In Electron's NSH installer version, the

ManifestDPIAware true

in build/~~~/installer.nsh to display a beautiful installer screen.

We hope you will consider this!
Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Windows NSIS installer script under build/; the issue identifies installer.nsh and the ManifestDPIAware setting to investigate. Compare the relevant Electron NSIS installer configuration, then verify that the Windows installer renders correctly on high-DPI displays.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron
Domain
build-system, release
Issue type
Feature
Difficulty
1/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.