http://subdomain.localhost valid url are not clickable
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 44.7k
- Forks
- 3.6k
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
- I am on the latest Hyper.app version
- I have searched the issues of this repo and believe that this is not a duplicate
- OS version and name: macOS Big Sur 11.14
- Hyper.app version: 3.1.4
- The issue is reproducible in vanilla Hyper.app: Is vanilla
Issue
Urls like http://localhost:3000 or http://localhost are hoverable and clickable in Hyper.
Subdomain of localhost like http://subdomain.localhost are currently NOT hoverable and clickable in Hyper.
Would be possible to modify the regex for urls to also make these valid localhost urls with sudomain are hoverable and clickable?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Hyper's URL-matching and hover/click handling entry point, then reproduce the behavior with http://localhost:3000 and http://subdomain.localhost. Done means localhost subdomains are recognized as hoverable and clickable without breaking the existing localhost cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100