vercel / vercel/hyper

Option to disable bold text changing to bright colors

Open
#5,361 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🛠 Type: Feature Request
Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

Is your feature request related to a problem? Please describe.
I don't want the color of bold text to change to the brighter version.

Describe the solution you'd like
I want an option to turn off the bold text color change.

In the underlying xterm.js library, there is a flag in ITerminalOptions called drawBoldTextInBrightColors, which by default is set true. I assume that setting this flag false will give my desired behavior. Can this be exposed as an option in the hyper.js config file? It looks like the getTermOptions function in hyper/lib/components/term.tsx can be changed to accept this additional option. Probably needs to be changed in other places as well.

I'm not the first to bring up this issue, but I haven't seen anyone mention the flag in the xterm.js library, so I assume it's relatively new. If that flag works as described, this should be a straightforward feature to implement.

Describe alternatives you've considered
I looked into making a plugin, but it doesn't look like the right way to solve this problem.

Additional context
Screenshot shows current unwanted behavior:
Screen Shot 2021-02-26 at 8 14 31 PM

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in hyper/lib/components/term.tsx, especially getTermOptions, and trace how terminal options are sourced from the hyper.js config file. Confirm how xterm.js's drawBoldTextInBrightColors option is represented, then expose the configuration option so disabling it prevents bold text from changing to bright colors.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.