A few issues I have and some bugs Ive noticed
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 44.7k
- Forks
- 3.6k
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
-
[x ] I am on the latest Hyper.app version
-
[x ] I have searched the issues of this repo and believe that this is not a duplicate
-
Win10 19041.329 / WSL2.0 / Ubuntu 18.04 / zsh 5.4.2
-
Hyper v3.0.2 stable
-
Is Vanilla
---------------------ISSUES
I was asked in another thread I commented in to open a new issue detailing what I have noticed
- "fontWeightBold" - bold text turning VERY small, incorrect spacing etc.
This setting is detailed as having two option, (iirc), "bold" and "normal", however I've noticed it DOES take an integer argument using the CSS standard weights 100-900. If you put in a number that isnt an increment of 100 it chooses the closest one available - HOWEVER, if you input a value above 1000 this happens. Ive also noticed it occur with 0 but that seems to just take on the previous value internally
Now no one is gonna input 1200 as their font weight, HOWEVER, if the string you use is not "bold" or "normal" this happens as well, for any string. I discovered this I believe because I had accidentally quoted an integer value ,thus rendering it a string.
Here are some images:
With: https://i.imgur.com/Gvl9tqo.png
Without: https://i.imgur.com/K0ZGxcy.png
-
"lineHeight" - settings below 1 cause hyper to crash
I use vscode and in vscode a setting of "0" for lineheight and letter spacing defaults to the font's own internal values for these. But setting this to 0 in hyper causes the renderer process to start consuming basically all your ram in an instant.
One caveat to this I noticed is that if you set it to 0 nothing really happens - until you reload hyper, then it will load but your shell will not, youll just see a blank canvas and your computer will start to get very loud as the fans all go on turbo. -
ALT + Arrow sends the same sequence as CTRL + arrow.
Took me a while to figure out why in nano I had to use "alt+left/right" to jump words rather than CTRL like was defined, but I figured out the other day that by default hyper rebinds CTRL+left/right to CTRL+f and CTRL+b.. would be nice to know what the keybinding settings are actually rebinding - in this case "edito:moveNextWord" is CTRL+F and "editor:movePreviousWord" is CTRL+B ...
So I edited it and now CTRL+left/right works, but alt is still working.
As it turns out, hyper sends the same key sequence for ALT and CTRL when in comination with the arrow keys, so for instance CTRL+left sends the sequence ^[[1;5D and ALT+left sends the same thing, whereas it SHOULD be ^[[1;3D
- environment settings - more a question
With the last comment, I did some digging and have noticed many differences between this and other terminals and I want to create my own terminfo source file to reference when I am using Hyper. but I can't get this to work properly, for instance:
env: { TERM: "HYPER" },does not change the term variable, now I figure maybe because it doesnt have a HYPER definition yet in the terminfo db on my system, so I set it toxtermand it sitll showsxterm256-color.
Okay so how about I create my own env variable and send that? so I try
env: { HYPER: true },orenv: { HYPER: 1} ,
and no variable is added to my environment. So I try setting another var that exists but doesnt have a setting, "WSLENV":
`` env: { WSLENV: "HYPER" },`
and I end up with the WSLENV environment var set to HYPER, as as well a now existing HYPER environment variable set to null.
Maybe this last one is a WSL thing, but still I cannot seem to set TERM to anything from Hypers end unless I do it in my rc file (.zshrc in this case), which Ive recently learned you should NOT do, the terminal should be setting this, not you.
Anyway, enjoy.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by reproducing the four reported behaviors on the listed Hyper, Windows, WSL2, Ubuntu, and zsh versions, separating the font, line-height, modifier-key, and environment cases. Done means each case has a confirmed scope and appropriate regression coverage or a maintainer-approved explanation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- linux, typescript, zsh
- Domain
- cli, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100