vercel / vercel/hyper

IPv6 links aren't clickable

Open
#3,953 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: macOS 10.12.6 (16G2136)
  • Hyper.app version: Hyper 3.0.2 (stable)
  • Link of a Gist with the contents of your .hyper.js: N/A
  • Relevant information from devtools N/A
  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

This will have no links at all.

2019-11-06T04:54:08.955Z           storyboard INFO  ┌── ROOT STORY: Node.js 12.5.0 on Darwin 64-bit, SB 3.1.4 [CREATED]
2019-11-06T04:54:08.956Z           storyboard INFO  Log filter: *:DEBUG
2019-11-06T04:54:09.616Z           storyboard INFO  Logs available via web on port 8090
2019-11-06T04:54:09.620Z                 main INFO  🚀 Playground ready at http://[::]:5000/graphql

Yet this will have a clickable link under http://localhost:5000/graphql.

2019-11-06T04:54:08.955Z           storyboard INFO  ┌── ROOT STORY: Node.js 12.5.0 on Darwin 64-bit, SB 3.1.4 [CREATED]
2019-11-06T04:54:08.956Z           storyboard INFO  Log filter: *:DEBUG
2019-11-06T04:54:09.616Z           storyboard INFO  Logs available via web on port 8090
2019-11-06T04:54:09.620Z                 main INFO  🚀 Playground ready at http://localhost:5000/graphql

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the two log examples in Hyper and inspect the terminal's link-detection and URL-handling entry points. Compare bracketed IPv6 URLs with localhost URLs, then verify that the IPv6 address and full path become clickable without breaking existing links.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.