vercel / vercel/hyper

`hyper search` output contains garbled text in some code page on Windows

Open
#3,832 0 comments 0 reactions 1 assignee View on GitHub

@chabou is already working on this.

Since Oct 10, 2019.

⌨️ CLI tool
Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows
  • Hyper.app version: 3.0.2
  • Link of a Gist with the contents of your .hyper.js: (Default config except that the shell is powershell)
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A
  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

On my device, the default code page of shells is 936 (Simplified Chinese). When I do hyper search, the ✅❎ signs are replaced by garbled text:

huang ~ env:base ❯❯❯ hyper search hyper
鈭?Searching
# Results...

==========

huang ~ env:base ❯❯❯ hyper search hypers
脳 Searching
Your search 'hypers' did not match any plugins
Try hyper ls-remote

When I change the code page to UTF-8 with chcp 65001 in hyper, the problem persists.

When I open another terminal, for me I used Microsoft Store version of Windows Terminal Preview (which by default uses 936 as well) and do the same thing, the problem also appears. When I change its code page to UTF-8, the problem disappears.

huang ~ env:anaconda ❯❯❯ hyper search hyper 
√ Searching 
# Results...

==========

huang ~ env:anaconda ❯❯❯ hyper search asdf
× Searching
Your search 'asdf' did not match any plugins
Try hyper ls-remote

I am using the same font for two terminals, and it supports these characters.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.