vercel / vercel/hyper

PECL install input fails to accept return key

Open
#3,782 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: macOS High Sierra - 10.13.6 (17G8030)
  • Hyper.app version: 3.0.2
  • Link of a Gist with the contents of your .hyper.js: Gist
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A
  • The issue is reproducible in vanilla Hyper.app: Replicated on vanilla

Issue

When installing an extension using PECL, the user may be prompted to provide configuration input. When running this through Hyper, the user is unable to complete the input form as the return key does not perform the expected operation.

Expected: The user completes the form field, hits return and proceeds to the next step.

Actual: The return key action appends ^M to the input string

Observed output:

$ pecl install amqp
downloading amqp-1.9.4.tgz ...
Starting to download amqp-1.9.4.tgz (102,604 bytes)
........................done: 102,604 bytes
28 source files, building
running: phpize
Configuring for:
PHP Api Version:         20170718
Zend Module Api No:      20170718
Zend Extension Api No:   320170718
Set the path to librabbitmq install prefix [autodetect] : test^M^M^M^M^M

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in vanilla Hyper by running pecl install amqp and submitting configuration input when prompted. Trace the terminal input handling for the return key and verify that the form advances without appending ^M to the entered value.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, typescript
Domain
cli, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.