vercel / vercel/hyper

Ctrl+C not killing Node Windows 10, Background Process Created?

Open
#3,659 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • Your Hyper.app version is 3.0.2. Please verify your using the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate

  • Any relevant information from devtools? (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
    N/A

  • Is the issue reproducible in vanilla Hyper.app?
    Yes.

Issue

Pressing Ctrl+C to quit certain applications spawned by npm do not kill the application (and more).

Verified this by changing the shell config option to be both Powershell and CMD and they both fail. Using bash however does not produce the same result. This seems to have something to do with Windows specifically.

I tested trying to stop the same process on CMD and Powershell not within Hyper and it works fine, so there is something causing this to happen only within the Hyper terminal itself.

I'm not sure this can be reproduced for others, but the exact command I run for my example happens to be something with npm start or npm run dev for example. One project runs a Koa server with Next.js, the other is using cgb-scripts. I also tried on another project with npm build which runs an electron build step and that also cannot be killed with Ctrl+C. Running node itself, the application will close just fine.

Closing the tab will NOT kill the process. If I close the tab, it will keep the process alive in the background. The only way to stop it, is by ending it in the Task Manager or Resource Monitor.

This has only been a recent issue since Hyper 3.

  • Hyper version: undefined "3.0.2"

  • OS ARCH VERSION: win32 x64 10.0.17763

  • Electron: 3.1.3 LANG: undefined

  • SHELL: undefined TERM: undefined

~/.hyper.js contents
        
          {
  "updateChannel": "stable",
  "fontSize": 12,
  "fontFamily": "Menlo, \"DejaVu Sans Mono\", Consolas, \"Lucida Console\", monospace",
  "fontWeight": "normal",
  "fontWeightBold": "bold",
  "lineHeight": 1,
  "letterSpacing": 0,
  "cursorColor": "rgba(248,28,229,0.8)",
  "cursorAccentColor": "#000",
  "cursorShape": "BLOCK",
  "cursorBlink": false,
  "foregroundColor": "#fff",
  "backgroundColor": "#000",
  "selectionColor": "rgba(248,28,229,0.3)",
  "borderColor": "#333",
  "css": "",
  "termCSS": "",
  "showHamburgerMenu": "",
  "showWindowControls": "",
  "padding": "12px 14px",
  "colors": {
    "black": "#000000",
    "red": "#C51E14",
    "green": "#1DC121",
    "yellow": "#C7C329",
    "blue": "#0A2FC4",
    "magenta": "#C839C5",
    "cyan": "#20C5C6",
    "white": "#C7C7C7",
    "lightBlack": "#686868",
    "lightRed": "#FD6F6B",
    "lightGreen": "#67F86F",
    "lightYellow": "#FFFA72",
    "lightBlue": "#6A76FB",
    "lightMagenta": "#FD7CFC",
    "lightCyan": "#68FDFE",
    "lightWhite": "#FFFFFF"
  },
  "shell": "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
  "shellArgs": [
    ""
  ],
  "env": {},
  "bell": "SOUND",
  "copyOnSelect": false,
  "defaultSSHApp": true,
  "quickEdit": false,
  "macOptionSelectionMode": "vertical",
  "webGLRenderer": true
}
      {

"plugins": [
"hyper-dracula"
],
"localPlugins": []
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the problem in Hyper 3.0.2 on Windows 10 using PowerShell or CMD, then compare Ctrl+C and tab closing for npm start, npm run dev, or npm build processes with behavior outside Hyper. Done means spawned processes terminate reliably when interrupted or when their tab closes, without remaining in the background.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, node.js, powershell, typescript
Domain
cli, desktop, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.