vercel / vercel/hyper

Powerline spacing regression in 3.0.0

Open
#3,575 30 comments 33 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

WebGL Renderer
Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10 1809
  • Hyper.app version: 2.1.2 and 3.0.0
  • Link of a Gist with the contents of your .hyper.js: Unmodified except for setting font family and size, and adding hyper-solarized-dark plugin
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
  • The issue is reproducible in vanilla Hyper.app: Yes

Issue

I tried out the latest 3.0.0 canary 8, and there is a significant regression in the display of Powerline arrow symbols. I searched existing issues and found several discussing Powerline font-related issues but none that seemed specific to rendering differences between v2.1.2 and v3.0.0. I am using zsh + oh-my-zsh with the popular agnoster theme. Font does not seem to be an issue -- behavior is the same under Consolas Nerd Font and Fira Code. The spacing / coloring is off significantly in v3 to the point of being distracting. It was never perfect in v2, but it was far better, and identical to vscode so the imperfections are almost certainly an upstream issue for xterm.js. Easiest to demonstrate with screenshots:

hyper-powerline-2 1 2
Hyper v2.1.2

hyper-powerline-3 c 8
Hyper v3.0.0 canary 8

vscode-powerline
VS Code

powershell-powerline
Powershell (perfect rendering)

I have uninstalled the solarized-dark plugin to revert Hyper to stock settings, but this did not have any effect on this issue. Any ideas on what I could do to get v3 at least back to the quality level of v2?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the comparison on Windows 10 using Hyper 2.1.2 and 3.0.0 canary 8, with the agnoster theme and the reported fonts. Compare Powerline arrow spacing and coloring against the screenshots and investigate the xterm.js rendering path mentioned in the report. Done means the v3 display is restored to at least the v2 quality level without the solarized-dark plugin.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.