vercel / vercel/hyper

Padding can't be set to 0

Open
#3,363 5 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: macOS 10.14
  • Hyper.app version: 2.1.0
  • Link of a Gist with the contents of your .hyper.js: default config

Issue

Setting padding to 0 doesn't actually set padding/margin to 0

screen shot 2018-12-23 at 3 33 55 pm

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Hyper 2.1.0 on macOS 10.14 using the default .hyper.js and a padding value of 0. Then trace how the configuration is applied to the terminal styling and verify that zero padding produces no unintended padding or margin.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
desktop, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.