vercel / vercel/hyper

In-app update notification notes link is 404ing

Open
#3,313 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10 latest
  • Hyper.app version: 2.1.0 canary2

In-app notficaiton notes link isn't being generated correctly. Latest pop-up linked to the this:
https://github.com/zeit/hyper/releases/tag/2.1.0-canary3

Should have linked to this

https://github.com/zeit/hyper/releases/tag/2.1.0-canary.3

dot between canary and 3 appears to be missing.

https://github.com/zeit/hyper/issues/2636 and https://github.com/zeit/hyper/pull/2637 will probably lead to the place the dot is being dropped

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing issues #2636 and pull request #2637, then trace the in-app update notification's notes-link generation. Compare the generated canary release URL with the expected URL and confirm that the dot is preserved before considering the issue done.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop, release
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.