vercel / vercel/hyper

JavasScript error opening new window (macOS Mojave)

Open
#3,299 9 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version (2.0.0)

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: macOS Mojave

  • Hyper.app version: 2.0.0

  • Link of a Gist with the contents of your .hyper.js: (started with it removed, it is the default)

  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A

  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

Just tried to install stock Hyper first time user on macOS Mojave. Trying to open a shell window, I get a JavaScript error, and the terminal window closes:

Uncaught Exception:
TypeError: Cannot read property 'resize' of undefined
    at Server.Window.rpc.on (/private/var/folders/48/hq3502h10mg0_1t71j3j25wm0000gn/T/AppTranslocation/FE61E0F7-C5EE-442F-B882-960E3A3D5D11/d/Hyper.app/Contents/Resources/app.asar/ui/window.js:146:14)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at Server.ipcListener (/private/var/folders/48/hq3502h10mg0_1t71j3j25wm0000gn/T/AppTranslocation/FE61E0F7-C5EE-442F-B882-960E3A3D5D11/d/Hyper.app/Contents/Resources/app.asar/rpc.js:33:11)
    at emitTwo (events.js:125:13)
    at EventEmitter.emit (events.js:213:7)
    at WebContents.<anonymous> (/private/var/folders/48/hq3502h10mg0_1t71j3j25wm0000gn/T/AppTranslocation/FE61E0F7-C5EE-442F-B882-960E3A3D5D11/d/Hyper.app/Contents/Resources/electron.asar/browser/api/web-contents.js:266:13)
    at emitTwo (events.js:125:13)
    at WebContents.emit (events.js:213:7)

Basically, it seems impossible for me to even try this application.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at ui/window.js:146, using the reported macOS Mojave setup and the steps for opening a shell window to reproduce the exception. Read the related rpc.js stack frame and verify that opening a new window no longer triggers the undefined resize error or closes the terminal window.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, javascript, macos
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.