Hyper closes tabs before before-quit event.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 44.7k
- Forks
- 3.6k
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
- I am on the latest Hyper.app version
- I have searched the issues of this repo and believe that this is not a duplicate
- Cross-platform:
- Hyper 2.0 / Canary:
Issue
Hyper 2.0 and master close all tabs/terminals prior to the before-quit event handlers running.
One result of this change is that plugins, like hyper-confirm, cannot prompt the user before closing the terminals. The user can be prompted, but it's too late, since Hyper has already closed everything.
I would think Hyper should be waiting for the will-quit event to fire before closing terminals.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the before-quit and will-quit event handling and the terminal/tab shutdown path in Hyper 2.0 or master. Reproduce the close flow with a plugin such as hyper-confirm, then verify that the before-quit handler can run before terminals are closed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100