vercel / vercel/hyper

White line / top border after Mojave upgrade?

Open
#3,259 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate

Issue

After upgrading to Mojave, I notice electron apps have a harsh white border at the top, which is especially noticeable on dark backgrounds. It happens in both dark and light mode. In this case, I have border: 0 !important; styling on my hyper window, so that you can see how apparent it is without the default hyper border...

screen shot 2018-10-17 at 10 58 56 am

I've also heard people say that all (even non-electron) windows have it, but native windows look way more natural than electron windows...

screen shot on 2018-10-17 at 09_15_29

I realize this might be actually on electron to fix (see https://github.com/electron/electron/issues/13164), but in that thread apparently the VS Code Insiders build has a 'fix', so I thought I'd share here in case it might be something that could be remedied on Hyper's end?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the white top border in Hyper 2.1.0-canary.2 on macOS Mojave, first checking the linked .hyper.js configuration and then testing vanilla Hyper through the devtools entry point. Compare the result with Electron issue #13164 and determine whether Hyper has a remedy; done means the unwanted border is absent without breaking the window styling.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, electron
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.