After hot reloading cmd-t and cmd-w perform their action twice
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 44.7k
- Forks
- 3.6k
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
- I am on the latest Hyper.app version
- I have searched the issues of this repo and believe that this is not a duplicate
- OS version and name: OSX 10.13.6
- Hyper.app version: 2.0.0
- Link of a Gist with the contents of your .hyper.js: https://gist.github.com/Mossop/365a8537f545fdeb08c0ed1dd2285d2a
- Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A
- The issue is reproducible in vanilla Hyper.app: Is Vanilla
Issue
After a hot reload (view -> reload) pressing Cmd-T opens two tabs. Pressing Cmd-W closes two tabs. The more times you reload the more tabs those operate on. You have to restart the application to get back to single tab actions.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in Hyper.app on macOS by reloading through View > Reload, then pressing Cmd-T and Cmd-W repeatedly. Start by tracing the hot-reload handling and keyboard shortcut registration; done means repeated reloads leave each shortcut acting on exactly one tab.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100