vercel / vercel/hyper

`showHamburgerMenu: false` should use Application Menu

Open
#3,202 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Ubuntu 18.04
  • Hyper.app version: 2.0.0
  • Link of a Gist with the contents of your .hyper.js: (See below)
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

I have the following in my .hyper.js. I am running Ubuntu 18.04 (GNOME) which supports "Application Menus"; however, when showHamburgerMenu is set to false, hyper does not utilize the Application Menu and instead uses context menus, despite not being context-specific.

    // if you're using a Linux setup which show native menus, set to false
    // default: `true` on Linux, `true` on Windows, ignored on macOS
    showHamburgerMenu: false,

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the showHamburgerMenu configuration and the Linux menu setup. Reproduce the behavior on Ubuntu 18.04 with showHamburgerMenu set to false, then verify that Hyper uses the desktop Application Menu instead of context menus.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.