vercel / vercel/hyper

Copy / paste sometimes does not respect line endings

Open
#3,063 4 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10 18.03
  • Hyper.app version: 2.0.0 (stable)
  • Link of a Gist with the contents of your .hyper.js:
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

The issue can basically be summed up with this:

root@ubuntu-1804:~# ll /home/tom/total 164drwxr-xr-x 18 tom  tom   4096 May 27 02:29 ./
drwxr-xr-x  3 root root  4096 May 23 13:20 ../
-rw-------  1 tom  tom    828 May 25 15:16 .bash_history
-rw-r--r--  1 tom  tom    220 May 23 13:20 .bash_logout
-rw-r--r--  1 tom  tom   3771 May 23 13:20 .bashrcdrwx------ 13 tom  tom   4096 May 23 14:34 .cache/drwx------ 12 tom  tom   4096 May 23 14:21 .config/drwxr-xr-x  2 tom  tom   4096 May 23 13:24 Desktop/drwxr-xr-x  2 tom  tom   4096 May 23 13:24 Documents/drwxr-xr-x  2 tom  tom   4096 May 23 13:24 Downloads/drwx------  3 tom  tom   4096 May 23 13:25 .gnupg/
-rw-------  1 tom  tom  10764 May 27 02:29 .ICEauthority
drwx------  3 tom  tom   4096 May 23 13:24 .local/
drwx------  5 tom  tom   4096 May 23 14:34 .mozilla/
drwxr-xr-x  2 tom  tom   4096 May 23 13:24 Music/
drwxr-xr-x  2 tom  tom   4096 May 23 13:24 Pictures/
-rw-r--r--  1 tom  tom    807 May 23 13:20 .profile
drwxr-xr-x  2 tom  tom   4096 May 23 13:24 Public/
drwxrwxr-t  2 tom  tom   4096 May 23 14:03 shared-drives/
drwx------  2 tom  tom   4096 May 23 13:25 .ssh/
-rw-r--r--  1 tom  tom      0 May 23 13:27 .sudo_as_admin_successful
drwxr-xr-x  2 tom  tom   4096 May 23 13:24 Templates/
drwxr-xr-x  2 tom  tom   4096 May 23 13:24 Videos/
-rw-------  1 tom  tom   1791 May 25 14:33 .viminfo
drwx------  2 tom  tom   4096 May 23 14:49 .vnc/
-rw-------  1 tom  tom     57 May 23 14:50 .Xauthority
-rw-r--r--  1 tom  tom  14863 May 23 14:57 .xorgxrdp.10.log
-rw-r--r--  1 tom  tom  18968 May 23 14:49 .xorgxrdp.10.log.old
-rw-------  1 tom  tom  19112 May 23 14:50 .xsession-errors
root@ubuntu-1804:~#

You can see that some lines have been concatenated after previous lines without keeping the newline. This only seems to happen with defaultSSHApp = true set and while SSH'd into another machine.

I am currently working around his by setting it to false. To be honest, I don't know what difference that makes to me as a user, other than that copy / paste now works. Some clarification on this in the documentation would be nice.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the copy/paste problem on Windows 10 with Hyper 2.0.0, an SSH session, and defaultSSHApp enabled, then compare it with the reported workaround setting. Done means copied terminal output preserves line endings, with the relevant behavior or setting documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.