Unreadable nano labels if backgroundColor is transparent
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 44.7k
- Forks
- 3.6k
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
- OS version and name: MacOS 10.13.4
- Hyper.app version: 2.0.0
- Link of a Gist with the contents of your .hyper.js: https://gist.github.com/lordgiotto/478485df770ef3a09359617453c3c115
- Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A
- The issue is reproducible in vanilla Hyper.app: With Vanilla Hyper.app, except for backgroundColor setting.
Issue
There are a lot of similar opened issues, but all miss the steps to reproduce the bug.
I noticed that it depends on backgroundColor setting.
Nano labels are not readable if backgroundColor setting is an rgba color with opacity different from 1.
Thanks for your great work btw :)
backgroundColor: 'rgba(0, 0, 0, .9)',
backgroundColor: 'rgba(0, 0, 0, 1)',
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in vanilla Hyper.app with the backgroundColor setting in .hyper.js, comparing rgba opacity below 1 with opacity 1. Trace the nano label rendering and styling from that configuration; done means labels remain readable with translucent background colors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, javascript
- Domain
- cli, desktop, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100