vercel / vercel/hyper

SESSION_ADD_DATA data is not readable.

Open
#2,982 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Mac OS 10.13.4
  • Hyper.app version: 2.0.0 (stable)
  • Link of a Gist with the contents of your .hyper.js:
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
  • The issue is reproducible in vanilla Hyper.app: yes

Issue

action.data in SESSION_ADD_DATA is not readable:

lib/actions/sessions.js line 52:

export function addSessionData(uid, data) {
  return (dispatch, getState) => {
    dispatch({
      type: SESSION_ADD_DATA,
      data,
      effect() {
        const session = getState().sessions.sessions[uid];
        const now = Date.now();
        if (session) {
          const enterKey = data.indexOf('\n') > 0;
          const url = enterKey ? isUrl(session.shell, data) : null;
          if (url) {
            return dispatch({
              type: SESSION_URL_SET,
              uid,
              url
            });
          }
        }
        dispatch({
          type: SESSION_PTY_DATA,
          uid,
          data,
          now
        });
      }
    });
  };
}

Dispatches an un-readable data:

screen shot 2018-05-06 at 12 59 41 am

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in vanilla Hyper on macOS 10.13.4, then inspect lib/actions/sessions.js around line 52 and the SESSION_ADD_DATA dispatch. Use the reported unreadable output and DevTools information to trace the data flow; done means SESSION_ADD_DATA data is readable in the terminal.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.