vercel / vercel/hyper

Implement function keys above F12 (F12, F13, ... F24)

Open
#2,962 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

👆 Is Upstream
Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: macOS 10.13.4 High Sierra

  • Hyper.app version: 2.0.0

Issue

This is an upstream issue (xtermjs/xterm.js#1426), but I thought I'd track it here.

Hyper ignores function-keys to which my other terminals respond:

screen shot 2018-05-01 at 1 06 29 pmscreen shot 2018-05-01 at 12 31 30 pm

From my Issue over there:

I spent about an hour digging through the source, to see if I could add this myself; but I have no idea where KeyboardEvent.keyCode is coming from. (I tried to test this in the Inspector in FireFox, but I kept running into unrelated issues. )=)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with upstream xterm.js issue #1426 and trace how KeyboardEvent.keyCode is handled for function keys. Use the reported F12–F24 behavior as the acceptance check; done means Hyper no longer ignores those keys on the reported macOS setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.