vercel / vercel/hyper

Add a config option for selected text color setting

Open
#2,934 4 comments 12 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • Windows 10

  • Hyper.app 2.0.0 stable:

  • hyper.js

Issue

There is a config option for selection color
selectionColor: <color>

However, if you use this without a opacity value the selection will hide the text. It would be nice to have a way to set the selection color and the selection text color so the text in the selection would still be visible.

selectionColor: <color>
selectionText: <color>

possible default values would be to invert the foreground and background colors.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating how the selectionColor configuration option is read and how terminal selections render their text. Review existing configuration and rendering tests, if present, then define the new selection text-color behavior and verify that selected text remains readable with an explicitly configurable color.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.