vercel / vercel/hyper

Storing configuration within OneDrive is not supported

Open
#2,835 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

👆 Is Upstream 🖼 Platform: Windows help wanted 🤯 Type: Compatibility
Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate

Issue

With Hyper 2.0.0 on Windows 10, storing the .hyper.js configuration file in OneDrive with Files On Demand is not supported. Attempting to run commands such as hyper i hyper-snazzy returns the following error:

Error: EINVAL: invalid argument, fstat
    at tryStatSync (fs.js:519:13)
    at Object.fs.readFileSync (fs.js:555:3)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:508:29)
    at memoize (C:\Users\Joseph\AppData\Local\hyper\app-2.0.0\resources\bin\cli.js:19124:15)
    at d (C:\Users\Joseph\AppData\Local\hyper\app-2.0.0\resources\bin\cli.js:19118:22)
    at Object.exists (C:\Users\Joseph\AppData\Local\hyper\app-2.0.0\resources\bin\cli.js:19138:10)
    at checkConfig (C:\Users\Joseph\AppData\Local\hyper\app-2.0.0\resources\bin\cli.js:9924:11)
    at Args.args.command (C:\Users\Joseph\AppData\Local\hyper\app-2.0.0\resources\bin\cli.js:9940:3)
    at Args.runCommand (C:\Users\Joseph\AppData\Local\hyper\app-2.0.0\resources\bin\cli.js:11309:37)
    at Args.module.exports [as parse] (C:\Users\Joseph\AppData\Local\hyper\app-2.0.0\resources\bin\cli.js:15080:10)

The issue is resolved by disabling OneDrive's Files On Demand feature. The problem lies with libuv; it was fixed in v1.14.0. Node > 8.5.0 has the fixed version of libuv, but with Electron lagging behind Node, it doesn't look like this issue will be fixed until Electron 2.0 is released (looks like Node v8.9.3 will be included in that release).

For more details about the problem, see this issue thread from Node.js.

For those affected by this issue: turning off OneDrive's Files On Demand feature will fix the problem. Once Hyper starts using Electron 2.0 following its release, this issue should be fixed for good.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking Hyper's Electron version and the bundled CLI path shown in the stack trace, then compare its Node/libuv version with the versions mentioned in the issue. Verify the behavior with a .hyper.js stored in OneDrive with Files On Demand enabled; done means Hyper commands work without requiring that feature to be disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, node.js
Domain
cli, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.