Update prompt links to json instead of GitHub releases
Open
@leo is already working on this.
Since Apr 23, 2018.
🐛 Type: Bug
💛 Priority: Medium
🖼 Platform: Windows
- Dominant language
- TypeScript
- Stars
- 44.7k
- Forks
- 3.6k
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
- I am on the latest Hyper.app version
- I have searched the issues of this repo and believe that this is not a duplicate
- OS version and name: Windows 10 1709
- Hyper.app version: Canary.10
- Link of a Gist with the contents of your .hyper.js:
- Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
- The issue is reproducible in vanilla Hyper.app:
Issue
On Windows, the update prompt links to the json blob at https://releases-canary.hyper.is/update/win32/2.0.0-canary.10 instead of the GitHub releases page. Looking at https://github.com/zeit/hyper/blob/canary/app/updater.js#L72 we might end up with updateUrl instead of releaseUrl?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.