vercel / vercel/hyper

To support a single cross-platform settings file some of the settings should be platform specific (like in VS Code)

Open
#2,584 0 comments 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

💬 Feedback Wanted 🛠 Type: Feature Request good first issue help wanted
Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: Windows 10 1709, Ubuntu 16.04, Ubuntu 17.10, macOS Sierra

  • Hyper.app version: 1.4.8

Feature Request

At present, with only a single "shell", "shellArgs", and "env" options I must maintain three different configs for the different OS platforms (where the only difference is in these three settings). This requires me to synchronize the rest of the settings manually in order to have the same experience across platforms. This kind of defeats the purpose of a cross-platform tool such as this.

VS Code gets around this problem by providing settings that are platform specific and the tool figures out which setting to use based on which platform it is running on. This is how I can have a single setting for VsCode that is shared across all machines.

In VS Code the relevant settings section looks like this:

"terminal.integrated.env.linux": {},
"terminal.integrated.env.osx": {},
"terminal.integrated.env.windows": {},

"terminal.integrated.shell.linux": "sh",
"terminal.integrated.shell.osx": "sh",
"terminal.integrated.shell.windows": "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe",

"terminal.integrated.shellArgs.linux": [],
"terminal.integrated.shellArgs.osx": [
"-l"
],
"terminal.integrated.shellArgs.windows": [],

Perhaps we could use:

shell.linux
shellArgs.linux
env.linux
shell.windows

and so on.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue identifies no implementation files, tests, or entry points. Start by locating Hyper's configuration handling and platform selection, then define platform-specific shell, shellArgs, and env behavior for Windows, Linux, and macOS and add coverage showing the appropriate settings are selected.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.