vercel / vercel/hyper

Changing the text size should signal SIGWINCH

Open
#2,413 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🍎 Platform: Mac 🐧 Platform: Linux 🤯 Type: Compatibility
Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: MacOS
  • Hyper.app version: 2.0.2
  • Link of a Gist with the contents of your .hyper.js: Default
  • The issue is reproducible in vanilla Hyper.app: Yes.

Issue

Cmd++ and Cmd+- are used to change the size of the text in Hyper, which ultimately changes the viewport size. However, it doesn't appear SIGWINCH is being signaled to the underlying shell process.

It should be. :)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Cmd+/− text-size handlers and the viewport-resize path, then trace how the underlying shell process is notified. Done means resizing text and the viewport causes SIGWINCH to reach the shell; verify the behavior on macOS.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.