vercel / vercel/hyper

Not all settings prompt an auto reload when changed while the app is running

Open
#2,400 0 comments 0 reactions 1 assignee View on GitHub

@chabou is already working on this.

Since Apr 23, 2018.

🐛 Type: Bug
Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: Windows 10 Pro x64

  • Hyper.app version: 2.0.4

  • Link of a Gist with the contents of your .hyper.js: N/A

  • Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere): N/A

  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

When changing settings in the user PROFILE .hyper.js config file, it seems not all settings prompt an auto reload anymore.. It's a bit tricky to work out which ones are actually affected by this, because I've also found a few settings that simply don't do anything at the moment (cursorShape, for example).

So far, the settings I've found that don't prompt an auto reload are:

  • cursorBlink
  • copyOnSelect (I think, this one kept giving unpredictable behaviour for me)
  • quickEdit

In addition to this, the following settings do auto reload, but only when setting a new value. Clearing the string (to reset defaults) doesn't prompt a reload.

  • css
  • termCSS
  • showHamburgerMenu
  • showWindowControls

Just a few quick notes: I have not tried this yet with any plugins, nor have a tried setting any custom key maps..

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.