vercel / vercel/hyper

Plugin installation process dies when one of the plugins is blocked on your OS

Open
#2,224 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🐛 Type: Bug 💛 Priority: Medium
Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10 1703
  • Hyper.app version: 1.4.6
  • Link of a Gist with the contents of your .hyper.js:
  • Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere):
  • The issue is reproducible in vanilla Hyper.app:

Issue

plugins: [
    "hyper-snazzy",
    "hyper-statusline",
    "hypercwd"
  ],

So in this example here, hyper-statusline has blocked installation on win32 via

 "os": [
    "!win32"
  ],

Hyper will try to install it and fail, but since hypercwd comes after hyper-statusline in the plugins array, installation of it will not be triggered at all.

There also should be some sort of alert/warning when a plugin can't be installed because it is blocked.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the plugin installation flow and the .hyper.js plugins configuration described in the issue, then reproduce the failure on Windows with a plugin whose package metadata blocks win32. Done means installation continues to later plugins and presents a warning when a plugin is blocked by the operating system.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.