vercel / vercel/hyper

Ugly shadow on menubar reveal in fullscreen(macOS)

Open
#1,386 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🍎 Platform: Mac
Dominant language
TypeScript
Stars
44.7k
Forks
3.6k
Avg merge
21m
Merged PRs (30d)
1

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • macOS Sierra, Version 10.12.2 (16C68):
  • Hyper.app version, Version 1.1.0 (1.1.0.1408):
  • A gist with my .hyper.js contents:
  • I can reproduce this issue even without the hyperterm-material plugin:

Issue

I typically have at least one terminal window running in full screen on my system. I recently noticed that one revealing the menu bar when in full screen, there is an ugly shadow-like thing that appears under the menu bar. Following are few screenshots that demonstrate my issue.

screen shot 2017-01-11 at 15 00 05

It can be seen more clearly when I focus on the entire window in devtools.

screen shot 2017-01-11 at 15 08 20

See that little shadow below the window controls? That's what I'm talking about

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in a fullscreen Hyper.app window on macOS Sierra, with and without the hyperterm-material plugin, then inspect the window in devtools as shown in the report. Done means the shadow below the window controls is no longer visible when the menu bar is revealed.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.