ventoy / ventoy/LiveInjection

dos2unix

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
42
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Can i safely ignore this if all injected files were created on linux and should already have proper line endings?
or is it used by files in the archive, or script?

~/bin/ventoy-1.1.10-linux/live-injection-1.0
$./pack.sh 
packing sysroot ...
./pack.sh: 23: dos2unix: not found
packing live_injection ...
-e 

========== SUCCESS ============

thanks,

RS

EDIT

I looked in the script and only found it on one line;

dos2unix -q ./$workdir/hook.sh

i opened the hook.sh file, and it seems it already has UNIX(LF) line endings.
so I am guessing my original assumption should be correct? 🤔
If so you can close this.
Maybe you could edit the script to add a message or something?
or just skip that line if already on Linux? 🤔
Without knowing your original intentions its hard to give suggestions.

Thanks for making an otherwise awesome program!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with pack.sh, especially line 23 and the dos2unix -q ./$workdir/hook.sh invocation, then inspect hook.sh's line endings and run the packaging command shown in the issue. Determine whether the missing command affects generated files or only normalization, and make the script's behavior clear when dos2unix is unavailable or unnecessary.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.