vectordotdev / vectordotdev/vector
Commented environment variables are still attempted to be interpolated
Open
Nobody has claimed this yet.
domain: config
- Dominant language
- Rust
- Stars
- 22.6k
- Forks
- 2.3k
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 146
Description
When Vector is launched with this config
[sources.stdin]
type = "stdin"
# commented = "${UNDEFINED_VARIABLE}"
[sinks.console]
type = "console"
inputs = ["stdin"]
then, assuming that UNDEFINED_VARIABLE is not defined, there is a warning
Aug 25 13:48:36.037 WARN vector::topology::config::vars: unknown env var in config: "UNDEFINED_VARIABLE"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the TOML configuration from the issue with UNDEFINED_VARIABLE unset, then search the Rust codebase for the unknown env var in config warning and the environment-variable interpolation entry point. Confirm that interpolation ignores commented values and that the example no longer emits the warning, adding or updating a regression test if the relevant test location is found.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100